[PATCH] D150246: AMDGPU: Fix issue in shl(or) combine

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 15 03:33:12 PDT 2023


foad added a comment.

I think this is OK, but wouldn't it be simpler to transform `((a | c1) << c2) ==> (a << c2) | (c1 << c2)` and remove the knownbits check? Or do you think that would make the generated code worse overall?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150246/new/

https://reviews.llvm.org/D150246



More information about the llvm-commits mailing list