[PATCH] D150443: [KnownBits] Define and use intersectWith and unionWith

Mon May 15 03:25:52 PDT 2023

foad added a comment.

In D150443#4340284 <https://reviews.llvm.org/D150443#4340284>, @nikic wrote:

> In D150443#4340036 <https://reviews.llvm.org/D150443#4340036>, @foad wrote:
>
>>> - Can we call this union and intersect instead of join and meet? I think this will be more obvious to most readers.
>>
>> No because `union` is a keyword :-( Apart from that I think it is a good candidate. I did think seriously about `union`/`intersect`, as well as other options like `and`/`or`.
>
> Oh, so //that's// why the corresponding ConstantRange methods are called unionWith and intersectWith...

Thanks, I did not know about them. It seems best to copy that design.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150443/new/

https://reviews.llvm.org/D150443