[PATCH] D150510: [ELF] x86-64: place .lrodata, .lbss, and .ldata away from code sections

Mon May 15 02:37:56 PDT 2023

peter.smith added a comment.

The approach and the code looks good to me. As an Arm person I would prefer for someone involved in x86_64 to comment on the proposed changes from GNU ld. If there are none forthcoming then give me a ping. From the GNU ld code-base there look to be a few other architectures that have .ldata sections but none of them look to be supported by upstream LLD.

================
Comment at: lld/ELF/Writer.cpp:895
       rank |= RF_RODATA;
+    // Among PROGBITS sections, place .rodata closer to .text.
+    if (!(osec.flags & SHF_X86_64_LARGE && config->emachine == EM_X86_64))
----------------
Do you mean .lrodata in the comment above?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150510/new/

https://reviews.llvm.org/D150510