[PATCH] D150515: [ConstantFold] use StoreSize for VectorType byte checking

Jannik Silvanus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 15 00:25:58 PDT 2023

Previous message: [PATCH] D150347: [AMDGPU] Improve abs modifier usage
Next message: [PATCH] D150515: [ConstantFold] use StoreSize for VectorType byte checking
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

jsilvanus added a comment.

Thanks for the fix!

The test diff is good, we now pass the test correctly. 
The code change looks reasonable to me, but I'm not very familiar with it (which is why I didn't fix it myself).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150515/new/

https://reviews.llvm.org/D150515

Previous message: [PATCH] D150347: [AMDGPU] Improve abs modifier usage
Next message: [PATCH] D150515: [ConstantFold] use StoreSize for VectorType byte checking
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list