[PATCH] D150462: [AIX] Fixed malformed big archive when total archive file size is large than 4Gbytes

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

Sorry for not getting around to reviewing many of your patches. I'm very heavily loaded with my regular work commitments, and will be for the next couple of weeks at least. I'm just trying to review smaller patches in the meantime.



================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:708
+  uint64_t PrevOffset = 0;
+  uint16_t Index = 0;
   for (const NewArchiveMember &M : NewMembers) {
----------------
Why is `uint16_t` appropriate here? I don't think it's unfeasible for an archive to several several hundred thousand members in particularly big project. I'd stick with `uint32_t` unless this value directly matches up with a file format member that restricts it to `uint16_t`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150462/new/

https://reviews.llvm.org/D150462