[PATCH] D150536: [Docs][llvm-exegesis] Specify platform support for different modes

Clement Courbet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 14 23:02:30 PDT 2023


courbet added inline comments.


================
Comment at: llvm/docs/CommandGuide/llvm-exegesis.rst:37
 :program:`llvm-exegesis` currently only supports X86 (64-bit only), ARM (AArch64
-only), MIPS, and PowerPC (PowerPC64LE only) on Linux. Not all functionality is
-guaranteed to work on every platform.
+only), MIPS, and PowerPC (PowerPC64LE only) on Linux for capture mode (collecting
+performance data). Not all capture mode functionality is guaranteed to work on
----------------
This is called "benchmarking" elsewhere. Let's use that for consistency.


================
Comment at: llvm/docs/CommandGuide/llvm-exegesis.rst:40
+every platform. :program:`llvm-exegesis` also has a separate analysis mode that
+is supported on all platforms that LLVM is.
 
----------------
[nit] "on which LLVM is" ?


================
Comment at: llvm/tools/llvm-exegesis/README.md:10
 `llvm-exegesis` is quite platform-dependent and currently only supports a couple
-platform configurations.
+platform configurations for capture mode. The limiations are listed below.
+`llvm-exegesis` for analysis mode, `llvm-exegesis` is supported on all platforms
----------------
typo


================
Comment at: llvm/tools/llvm-exegesis/README.md:12
+`llvm-exegesis` for analysis mode, `llvm-exegesis` is supported on all platforms
+that LLVM itself is supported on.
 
----------------
on which


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150536/new/

https://reviews.llvm.org/D150536



More information about the llvm-commits mailing list