[llvm] 057e14d - [Coverity] Fix unchecked return value, NFC

Phoebe Wang via llvm-commits llvm-commits at lists.llvm.org
Sun May 14 03:50:26 PDT 2023


Author: Phoebe Wang
Date: 2023-05-14T18:50:20+08:00
New Revision: 057e14df70f046aee8ba50eeb3690870cb048b2d

URL: https://github.com/llvm/llvm-project/commit/057e14df70f046aee8ba50eeb3690870cb048b2d
DIFF: https://github.com/llvm/llvm-project/commit/057e14df70f046aee8ba50eeb3690870cb048b2d.diff

LOG: [Coverity] Fix unchecked return value, NFC

Added: 
    

Modified: 
    llvm/lib/CodeGen/MIRParser/MIParser.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/MIRParser/MIParser.cpp b/llvm/lib/CodeGen/MIRParser/MIParser.cpp
index 34fb64ea66ce3..fe30346e4291f 100644
--- a/llvm/lib/CodeGen/MIRParser/MIParser.cpp
+++ b/llvm/lib/CodeGen/MIRParser/MIParser.cpp
@@ -470,7 +470,7 @@ class MIParser {
   bool parseJumpTableIndexOperand(MachineOperand &Dest);
   bool parseExternalSymbolOperand(MachineOperand &Dest);
   bool parseMCSymbolOperand(MachineOperand &Dest);
-  bool parseMDNode(MDNode *&Node);
+  [[nodiscard]] bool parseMDNode(MDNode *&Node);
   bool parseDIExpression(MDNode *&Expr);
   bool parseDILocation(MDNode *&Expr);
   bool parseMetadataOperand(MachineOperand &Dest);
@@ -3471,7 +3471,8 @@ bool MIParser::parseHeapAllocMarker(MDNode *&Node) {
   assert(Token.is(MIToken::kw_heap_alloc_marker) &&
          "Invalid token for a heap alloc marker!");
   lex();
-  parseMDNode(Node);
+  if (parseMDNode(Node))
+    return true;
   if (!Node)
     return error("expected a MDNode after 'heap-alloc-marker'");
   if (Token.isNewlineOrEOF() || Token.is(MIToken::coloncolon) ||
@@ -3487,7 +3488,8 @@ bool MIParser::parsePCSections(MDNode *&Node) {
   assert(Token.is(MIToken::kw_pcsections) &&
          "Invalid token for a PC sections!");
   lex();
-  parseMDNode(Node);
+  if (parseMDNode(Node))
+    return true;
   if (!Node)
     return error("expected a MDNode after 'pcsections'");
   if (Token.isNewlineOrEOF() || Token.is(MIToken::coloncolon) ||


        


More information about the llvm-commits mailing list