[llvm] bb97499 - Revert "[cmake] Disable GCC lifetime DSE" (to fix authorship)

Sam James via llvm-commits llvm-commits at lists.llvm.org
Sat May 13 19:46:33 PDT 2023


Author: Sam James
Date: 2023-05-14T03:42:27+01:00
New Revision: bb974991f4c4457a2104b648d9797a0ed438ecc9

URL: https://github.com/llvm/llvm-project/commit/bb974991f4c4457a2104b648d9797a0ed438ecc9
DIFF: https://github.com/llvm/llvm-project/commit/bb974991f4c4457a2104b648d9797a0ed438ecc9.diff

LOG: Revert "[cmake] Disable GCC lifetime DSE" (to fix authorship)

This reverts commit 94f7c961c78d8fdbc05898cfbbf88094de45c1ad.

Differential Revision: https://reviews.llvm.org/D150505

Added: 
    

Modified: 
    llvm/cmake/modules/HandleLLVMOptions.cmake

Removed: 
    


################################################################################
diff  --git a/llvm/cmake/modules/HandleLLVMOptions.cmake b/llvm/cmake/modules/HandleLLVMOptions.cmake
index 52cb2eaa3009..578a3169178e 100644
--- a/llvm/cmake/modules/HandleLLVMOptions.cmake
+++ b/llvm/cmake/modules/HandleLLVMOptions.cmake
@@ -594,16 +594,6 @@ if ( LLVM_COMPILER_IS_GCC_COMPATIBLE OR CMAKE_CXX_COMPILER_ID MATCHES "XL" )
   add_flag_if_supported("-Werror=unguarded-availability-new" WERROR_UNGUARDED_AVAILABILITY_NEW)
 endif( LLVM_COMPILER_IS_GCC_COMPATIBLE OR CMAKE_CXX_COMPILER_ID MATCHES "XL" )
 
-if ( LLVM_COMPILER_IS_GCC_COMPATIBLE )
-  # LLVM data structures like llvm::User and llvm::MDNode rely on
-  # the value of object storage persisting beyond the lifetime of the
-  # object (#24952).  This is not standard compliant and causes a runtime
-  # crash if LLVM is built with GCC and LTO enabled (#57740).  Until
-  # these bugs are fixed, we need to disable dead store eliminations
-  # based on object lifetime.
-  add_flag_if_supported("-fno-lifetime-dse" CMAKE_CXX_FLAGS)
-endif ( LLVM_COMPILER_IS_GCC_COMPATIBLE )
-
 # Modules enablement for GCC-compatible compilers:
 if ( LLVM_COMPILER_IS_GCC_COMPATIBLE AND LLVM_ENABLE_MODULES )
   set(OLD_CMAKE_REQUIRED_FLAGS ${CMAKE_REQUIRED_FLAGS})


        


More information about the llvm-commits mailing list