[llvm] 1a83865 - [Docs] Minor Fixups in Advanced Builds Documentation

Aiden Grossman via llvm-commits llvm-commits at lists.llvm.org
Sat May 13 15:47:46 PDT 2023


Author: Aiden Grossman
Date: 2023-05-13T15:43:39-07:00
New Revision: 1a83865b786c8dfa27123defcd08e272a30a4c13

URL: https://github.com/llvm/llvm-project/commit/1a83865b786c8dfa27123defcd08e272a30a4c13
DIFF: https://github.com/llvm/llvm-project/commit/1a83865b786c8dfa27123defcd08e272a30a4c13.diff

LOG: [Docs] Minor Fixups in Advanced Builds Documentation

This patch changes two instances of an ampersand to a written out and
for more consistency with the rest of the file and brevity. In addition,
the last `cmake --build` reference is removed, again for consistency
with the rest of the file which shows the ninja invocations. This cmake
invocation also passed in the `--parallel` flag which doesn't make sense
with ninja using all threads by default.

This was changed in the previous patch to touch this line
(https://reviews.llvm.org/D88990), but if we want to change this, it
should be done across the entire file.

Added: 
    

Modified: 
    llvm/docs/AdvancedBuilds.rst

Removed: 
    


################################################################################
diff  --git a/llvm/docs/AdvancedBuilds.rst b/llvm/docs/AdvancedBuilds.rst
index a172e5da63c4..960b19fa5317 100644
--- a/llvm/docs/AdvancedBuilds.rst
+++ b/llvm/docs/AdvancedBuilds.rst
@@ -270,12 +270,12 @@ and build a compiler (stage1), then use that compiler to rebuild the sources
 this, you have a stage2 and stage3 compiler that should be bit-for-bit
 identical.
 
-You can perform one of these 3-stage builds with LLVM & clang using the
+You can perform one of these 3-stage builds with LLVM and clang using the
 following commands:
 
 .. code-block:: console
 
   $ cmake -G Ninja -C <path to source>/clang/cmake/caches/3-stage.cmake <path to source>/llvm
-  $ cmake --build . --target stage3 --parallel
+  $ ninja stage3
 
-After the build you can compare the stage2 & stage3 compilers.
+After the build you can compare the stage2 and stage3 compilers.


        


More information about the llvm-commits mailing list