[PATCH] D150004: [RISCV][MC] .debug_line/.debug_frame/.eh_frame: emit relocations for assembly input files with relaxation

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 13 14:03:02 PDT 2023


barannikov88 added a comment.

@MaskRay 
Thank you for the explanation. Weighting all pros and cons I tend to agree with you.
I also apologize for taking so much of your time for this simple change.

One point I'd like to clarify, because it was one of my main concerns:

> Are you suggesting to remove the getAssemblerPtr() argument? AIUI this would prevent the fast path from ever being triggered, even for assembly input.

This will not prevent the fast path from being triggered because not all
expressions contain symbols. An expression can be as simple as 42. I'm not sure
if this can be the case for special directives like cfa / eh_frame though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150004/new/

https://reviews.llvm.org/D150004



More information about the llvm-commits mailing list