[PATCH] D150101: [ValueTracking] Add tests for knownbits of saturating add/sub functions; NFC

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 13 10:52:10 PDT 2023


goldstein.w.n added a comment.

In D150101#4339922 <https://reviews.llvm.org/D150101#4339922>, @RKSimon wrote:

> LGTM - I'm still unsure whether they give us anything over what the exhaustive tests provide

To test that they have as expected in valuetracking (I.e exhausting will pass for all bits unknown in all cases, but for our purposes thats a bug).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150101/new/

https://reviews.llvm.org/D150101



More information about the llvm-commits mailing list