[PATCH] D150099: [ValueTracking] Add tests for knownbits of `abs`; NFC
Noah Goldstein via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat May 13 10:48:59 PDT 2023
goldstein.w.n added a comment.
In D150099#4326321 <https://reviews.llvm.org/D150099#4326321>, @RKSimon wrote:
> LGTM - we already have the exhaustive tests in KnownBitsTest, but adding explicit test patterns for specific cases is fine.
I see there are two things we want to test. 1) that the knownbits transformations are correct. 2) that is behaves as is expected in valuetracking. Without case 2 we could have a bug that just set all unknown.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150099/new/
https://reviews.llvm.org/D150099
More information about the llvm-commits
mailing list