[PATCH] D150443: [KnownBits] Define and use meet and join operations

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 13 07:25:14 PDT 2023


nikic added a comment.

Two pieces of feedback on the API:

- Can we call this union and intersect instead of join and meet? I think this will be more obvious to most readers.
- The fact that the instance methods modify the value in place rather than returning a new one is rather surprising -- isn't the usual convention for KnownBits methods to return the result?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150443/new/

https://reviews.llvm.org/D150443



More information about the llvm-commits mailing list