[PATCH] D149916: [VP][SelectionDAG][RISCV] Add get_vector_length intrinsics and generic SelectionDAG support.
Fraser Cormack via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat May 13 00:40:17 PDT 2023
frasercrmck added inline comments.
================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7315
+
+ uint64_t VF = cast<ConstantInt>(I.getOperand(2))->getZExtValue();
+ SDValue MaxEVL = DAG.getVScale(sdl, TripCountVT,
----------------
craig.topper wrote:
> frasercrmck wrote:
> > Do we want to sanitize negative immediates here or elsewhere, or do we just let them become large positive ones?
> Good question. Do you have a suggestion how to sanitize it?
Would adding something to the verifier be sufficient? Then we may be able to assert here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149916/new/
https://reviews.llvm.org/D149916
More information about the llvm-commits
mailing list