[PATCH] D147991: [LLVM][Casting.h] Fix dyn_cast for std::unique_ptr.
Aman LaChapelle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 12 20:52:14 PDT 2023
bzcheeseman added inline comments.
================
Comment at: llvm/unittests/Support/Casting.cpp:232
+ EXPECT_NE(BP2.get(), nullptr);
+ BP2.release();
}
----------------
zuban32 wrote:
> bzcheeseman wrote:
> > I don't believe this is necessary? I think we want it to be deallocated.
> I was just following the chunk above, I think gtest reports some memory issue should we omit the `release()`. I don't remember why, let me take a look
Ah interesting. Thanks for looking into it!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147991/new/
https://reviews.llvm.org/D147991
More information about the llvm-commits
mailing list