[PATCH] D150004: [RISCV][MC] .debug_line/.debug_frame/.eh_frame: emit relocations for assembly input files with relaxation
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 12 16:12:23 PDT 2023
MaskRay added a comment.
In D150004#4339183 <https://reviews.llvm.org/D150004#4339183>, @barannikov88 wrote:
> I can't say that I'm convinced, but I ran out of arguments and I'm cowardly retreating.
> I hope this discussion will be helpful if something goes wrong in the future.
It's unfortunate that you feel the need to retreat. Could you please elaborate on the specific points that left you unconvinced? Otherwise there is a risk of causing confusion or misunderstanding.
(a) my statement that the linker relaxation support in MC is fragile
(b) my statement that the "fast paths" removed by this patch cause complexity and are unneeded
(c) my statement that adding an RISC-V check in `evaluateAsAbsolute` needs extreme attention
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150004/new/
https://reviews.llvm.org/D150004
More information about the llvm-commits
mailing list