[PATCH] D150488: [MemProf] Set hot/cold new values with option

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/SimplifyLibCalls.cpp:62
+
+  bool parse(cl::Option &O, StringRef ArgName, StringRef Arg, unsigned &Value) {
+    if (Arg.getAsInteger(0, Value))
----------------
tejohnson wrote:
> davidxl wrote:
> > Is 0 allowed ?
> Yes. The 0 value to getAsInteger is the radix value, and 0 means autosense (so it will accept e.g. hex, octal, etc with the appropriate prefix on the value).
My question is if value zero is allowed to be specified as a possible value or it is treated as a reserved value.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150488/new/

https://reviews.llvm.org/D150488