[PATCH] D150004: [RISCV][MC] .debug_line/.debug_frame/.eh_frame: emit relocations for assembly input files with relaxation

[Sergei Barannikov via Phabricator via llvm-commits]

barannikov88 added a comment.

> Assembly source files typically don't write CFI directives, and a bug is mostly unnoticeable anyway.

They do, if you use -save-temps :) But I agree that it is much less common.

There is also `MCObjectStreamer::emitValueImpl`, which potentially has the same issue.
I guess this is one of the reasons it was overridden for RISC-V, and fixing the base
version would impose much more significant slowdowns for other targets.

I'm wondering if RISCVELFStreamer::requiresFixups used in emitValueImpl could be
promoted to a virtual function in MCAsmBackend or MCObjectStreamer and used
in evaluateAsRelocatable? Or am I talking nonsense?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150004/new/

https://reviews.llvm.org/D150004