[PATCH] D134893: [LSR][TTI][RISCV] Add isAllowTerminatingConditionFoldingAfterLSR into TTI and enable it for RISC-V

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

In D134893#4210164 <https://reviews.llvm.org/D134893#4210164>, @reames wrote:

> I will note that I am generally skeptical of this being enabled on a per-target basis.

To circle back around here, I spent some time looking at the impact of this on other targets.  In short, this heuristic really only makes sense on RISCV at the moment.  Given this, my prior objection to a transform specific target hook no longer applies.

I do want to see some discussion of the testing this patch has been put through before we move forward with enabling it though.  I'd encourage a rebase and a summary comment describing any testing which has been done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134893/new/

https://reviews.llvm.org/D134893