[PATCH] D150002: [AMDGPU] Fix crash with 160-bit p7's by manually defining getPointerTy

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 12 09:36:01 PDT 2023


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:990
+MVT SITargetLowering::getPointerTy(const DataLayout &DL, unsigned AS) const {
+  if (AMDGPUAS::BUFFER_FAT_POINTER == AS && DL.getPointerSizeInBits(AS) > 128)
+    return MVT::v5i32;
----------------
foad wrote:
> Nit: why do you need the getPointerSizeInBits test?
I mean why do you need it at all? Don't we know statically that the size of BUFFER_FAT_POINTER is 160 bits?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150002/new/

https://reviews.llvm.org/D150002



More information about the llvm-commits mailing list