[PATCH] D150305: ObjCopy: support `--dump-section` on COFF

[Hiroshi Yamauchi via Phabricator via llvm-commits]

hjyamauchi accepted this revision.
hjyamauchi added inline comments.


================
Comment at: llvm/lib/ObjCopy/COFF/COFFObjcopy.cpp:133
 
+static Error dumpSection(Object &O, StringRef S, StringRef File) {
+  for (const coff::Section &Section : O.getSections()) {
----------------
jhenderson wrote:
> compnerd wrote:
> > hjyamauchi-test wrote:
> > > nit: "S" -> "Section" to match "File"?
> > That collides with the iterator - I can use `SectionName` but that also is different from `File` ... I guess I can do `SectionName` and `FileName`.
> +1 to `SectionName` and `FileName`. I think this nicely improves clarity.
+1


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150305/new/

https://reviews.llvm.org/D150305