[PATCH] D150436: Correct the sort logic in AsmMatcherEmmitter.cpp

Kan Shengchen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 12 07:58:37 PDT 2023


skan added inline comments.


================
Comment at: llvm/test/MC/X86/pr22028.s:17
 //CHECK16:	pushw	$257                    # encoding: [0x68,0x01,0x01]
-//CHECK16:	pushl	$65536                  # encoding: [0x66,0x68,0x00,0x00,0x01,0x00]
+//CHECK16:	pushw	$65536                  # encoding: [0x68,0x00,0x00]
 
----------------
barannikov88 wrote:
> Is this correct? 65536 does not fit into a 16-bit word.
> 
It aligns with the GAS's behavior.

bash$ cat 1.s

```
.code16
push 65536
```
bash$ as 1.s -o 1.o
bash$ objdump -M i8086 -d 1.o

```

0000000000000000 <.text>:
   0:   ff 36 00 00             pushw  0x0
```




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150436/new/

https://reviews.llvm.org/D150436



More information about the llvm-commits mailing list