[PATCH] D149968: [AArch64][SVE] Predicated mul pattern

[David Sherwood via Phabricator via llvm-commits]

david-arm added a comment.

Seems like a nice improvements - thanks @dmgreen! I just had one comment about the patterns.



================
Comment at: llvm/lib/Target/AArch64/AArch64SVEInstrInfo.td:412
+                             [(int_aarch64_sve_mul node:$pred, node:$op1, node:$op2),
+                              (vselect node:$pred, (AArch64mul_p (AArch64ptrue 31), node:$op1, node:$op2), node:$op1)]>;
 def AArch64mla_m1 : PatFrags<(ops node:$pred, node:$op1, node:$op2, node:$op3),
----------------
Should this be similar to the PatFrags below, i.e.

  (vselect node:$pred, (AArch64mul_p_oneuse (SVEAllActive),



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149968/new/

https://reviews.llvm.org/D149968