[PATCH] D144045: [InstCombine] Avoid sinking fdiv into a loop

Fri May 12 07:13:06 PDT 2023

david-arm marked an inline comment as done.
david-arm added a comment.

In D144045#4337318 <https://reviews.llvm.org/D144045#4337318>, @sdesmalen wrote:

> Did you do any performance runs to check if there were regressions? If so, we'd need to change some of the InstCombine instances to run in a different mode (suggestion (2) <https://reviews.llvm.org/D144045#4292250>) by explicitly forcing the canonical form regardless of LoopInfo. If not, I'm not sure if such an option is still worth adding.

I didn't see any change in performance when running SPEC2017 on neoverse-v1 and on a X86 machine. On neoverse-v1 I also ran some additional HPC benchmarks and some LLVM test suite workloads without seeing any regressions.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144045/new/

https://reviews.llvm.org/D144045