[PATCH] D136030: [ADT] Introduce StringRef::{starts,ends}_width{,_insensitive}
Aaron Ballman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 12 06:01:28 PDT 2023
aaron.ballman added a comment.
In D136030#4336939 <https://reviews.llvm.org/D136030#4336939>, @kazu wrote:
> In D136030#4329337 <https://reviews.llvm.org/D136030#4329337>, @aaron.ballman wrote:
>
>>> I'm planning to deprecate the existing functions in favor of the new ones.
>>
>> This landed 7 months ago and no deprecations have materialized. There are 58 uses of endswith_insensitive, there are uses 9 of ends_with_insensitive (all of which were introduced in this patch). 71 and 9 for startswith_insensitive vs starts_with_insensitive. What is the plan for cleaning this up? Alternatively, can we revert this patch as it doesn't seem particularly motivated?
>
> Oops. Apparently I dropped the ball. Let me migrate `startswith_insensitive` and `endswith_insensitive`.
Thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136030/new/
https://reviews.llvm.org/D136030
More information about the llvm-commits
mailing list