[PATCH] D147871: ValueTracking: Implement computeKnownFPClass for sqrt
Jay Foad via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri May 12 04:06:01 PDT 2023
foad added inline comments.
================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4150
+ return isKnownNeverNegZero() &&
+ (isKnownNeverNegSubnormal() || inputDenormalIsIEEE(F, Ty));
+}
----------------
There's a better version of this in D148230 that uses inputDenormalIsIEEEOrPosZero.
================
Comment at: llvm/lib/Analysis/ValueTracking.cpp:4491
+ (InterestedClasses & fcNan) != fcNone &&
+ cannotBeOrderedLessThanZeroImpl(II->getArgOperand(0), TLI, false,
+ Depth + 1))
----------------
This should reuse info from the first call to computeKnownFPClass, instead of making a second call to cannotBeOrderedLessThanZeroImpl.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147871/new/
https://reviews.llvm.org/D147871
More information about the llvm-commits
mailing list