[PATCH] D150190: [llvm-debuginfo-analyzer] Include linkage names while evaluating `--select`

Greg Bedwell via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 12 03:18:38 PDT 2023


gbedwell added a comment.

@CarlosAlbertoEnciso should review this ideally for approving, but I'm just nitpicking on a long line.



================
Comment at: llvm/include/llvm/DebugInfo/LogicalView/Core/LVOptions.h:514
     auto CheckPattern = [=]() -> bool {
-      return (Element->isNamed() && matchGenericPattern(Element->getName())) ||
+      return (Element->isNamed() && (matchGenericPattern(Element->getName()) || matchGenericPattern(Element->getLinkageName()))) ||
              (Element->isTyped() &&
----------------
clang-format?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150190/new/

https://reviews.llvm.org/D150190



More information about the llvm-commits mailing list