[PATCH] D149916: [VP][SelectionDAG][RISCV] Add get_vector_length intrinsics and generic SelectionDAG support.

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 12 02:42:09 PDT 2023


frasercrmck added a comment.

It looks good to me, but I'd like to leave it open for a bit so that other more active reviewers can take a look.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:7315
+
+    uint64_t VF = cast<ConstantInt>(I.getOperand(2))->getZExtValue();
+    SDValue MaxEVL = DAG.getVScale(sdl, TripCountVT,
----------------
Do we want to sanitize negative immediates here or elsewhere, or do we just let them become large positive ones?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149916/new/

https://reviews.llvm.org/D149916



More information about the llvm-commits mailing list