[PATCH] D150417: [LoongArch] Move lp64s out of the unimplemented calling conv list

WÁNG Xuěruì via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 11 23:38:25 PDT 2023


xen0n added a comment.

Thanks for the patch! Never thought it was //this// trivial to wire up LP64S. ;-)



================
Comment at: llvm/test/CodeGen/LoongArch/calling-conv-lp64s-lp64d-common.ll:5-6
+
+;; This file contains tests that should have identical output for the lp64s and
+;; lp64d ABIs. i.e. where no arguments are passed via floating point registers.
 
----------------
It sounds like we can avoid having to rename the file and change this comment one more time when we wire up LP64F, by rewording the sentence a little bit and renaming the file? Like "calling-conv-common.ll" (leaving room for e.g. "calling-conv-fp-common" or "calling-conv-vector-common") and "... identical output for all ABIs, i.e. ...".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150417/new/

https://reviews.llvm.org/D150417



More information about the llvm-commits mailing list