[PATCH] D150068: [X86][AsmParser] Refactor code in AsmParser

Thu May 11 22:05:32 PDT 2023

rupprecht added a comment.

In D150068#4336864 <https://reviews.llvm.org/D150068#4336864>, @skan wrote:

> In D150068#4336844 <https://reviews.llvm.org/D150068#4336844>, @rupprecht wrote:
>
>> Is it expected that this patch would cause any differences in the final binary? It seems to be just a refactoring, but we bisected a runtime crash to this commit.
>
> It should not cause any difference in binary in theory. Could you show the difference or provide a small reproducer?

I don't have anything yet, since it's an internal test case. I'm going to bisect what the difference is, but it's still reproducing a failure at this commit but not the one prior -- so _something_ must be different, I think.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150068/new/

https://reviews.llvm.org/D150068