[PATCH] D150334: [llvm-profdata] Use string ref for FunctionSamplesMap

[Hongtao Yu via Phabricator via llvm-commits]

hoy added a comment.



In D150334#4335933 <https://reviews.llvm.org/D150334#4335933>, @davidxl wrote:

> is there way to make sure the lifetime of underlying strings out lasts the SampleMap?

It should be ok, as the compiler and llvm-profdata both keep the underlying sample reader alive to the last minute. llvm-profgen should be fine too.

Wondering if Google's create-profile tool ever uses this DS.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150334/new/

https://reviews.llvm.org/D150334