[PATCH] D150305: ObjCopy: support `--dump-section` on COFF

Hiroshi Yamauchi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 11 15:34:13 PDT 2023


hjyamauchi added a comment.

In D150305#4336082 <https://reviews.llvm.org/D150305#4336082>, @MaskRay wrote:

> In D150305#4335987 <https://reviews.llvm.org/D150305#4335987>, @hjyamauchi-test wrote:
>
>> In D150305#4333439 <https://reviews.llvm.org/D150305#4333439>, @MaskRay wrote:
>>
>>> @hjyamauchi If you want to change username, I can help. Do you want to rename `yamauchi` to another name (which one?) and rename `hjyamauchi` to `yamauchi`?
>>> There may also be ways to find passwords for `yamauchi`.
>>
>> Hi Ray, thanks for the offer for help. I created the second account 'hjyamauchi' with the goal of integrating it with the login with my github account hjyamauchi@ and matching the github username and the phabricator username. Maybe that was my confusion around the github migration and it'd have been possible to switch an existing username/password-based account to a github login? I can log into both accounts. If possible, it might be best to rename 'yamauchi' to 'hjyamauchi' (and remove or rename the current 'hjyamauchi'), keep the review history from 'yamauchi' and integrate that with my github login.
>
> Done! Matching the GitHub account is a good reason and I know others renaming for this reason.
>
> Renamed to `hjyamauchi` to `hjyamauchi-test` and renamed `yamauchi` to `hjyamauchi` :)
> @hjyamauchi contains all the contribution history (all occurrences of `@yamauchi` in old messages are replaced with `@hjyamauchi`).
>
> If the result looks good, I can disable `hjyamauchi-test` so that people will not pick the wrong user.
> (Like that I had @maskray0 which has been disabled.)

Thanks! I'll see how the new 'hjyamauchi' works out and let you know. I'll also see if I can integrate it with my github login.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150305/new/

https://reviews.llvm.org/D150305



More information about the llvm-commits mailing list