[PATCH] D150305: ObjCopy: support `--dump-section` on COFF

[Hiroshi Yamauchi via Phabricator via llvm-commits]

hjyamauchi accepted this revision.
hjyamauchi added inline comments.


================
Comment at: llvm/lib/ObjCopy/COFF/COFFObjcopy.cpp:133
 
+static Error dumpSection(Object &O, StringRef S, StringRef File) {
+  for (const coff::Section &Section : O.getSections()) {
----------------
nit: "S" -> "Section" to match "File"?


================
Comment at: llvm/lib/ObjCopy/COFF/COFFObjcopy.cpp:152
+  }
+  return createStringError(errc::no_such_file_or_directory,
+                           "section '%s' not found", S.str().c_str());
----------------
nit: Would it be good to match the ELF version with "object_error::parse_failed"? Or the other way around? Perhaps doesn't matter.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150305/new/

https://reviews.llvm.org/D150305