[PATCH] D150107: [X86] Remove patterns for shift/rotate with immediate 1 and optimize during MC lowering

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86EncodingOptimization.cpp:139
+bool X86::optimizeRotateWithImmediate(MCInst &MI) {
+  unsigned NumOps = MI.getNumOperands();
+  if (!NumOps)
----------------
Why not check the opcode first?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150107/new/

https://reviews.llvm.org/D150107