[PATCH] D150375: [FuncSpec] Replace LoopInfo with BlockFrequencyInfo.

[Alexandros Lamprineas via Phabricator via llvm-commits]

labrinea created this revision.
labrinea added reviewers: chill, ChuanqiXu, SjoerdMeijer.
Herald added subscribers: hoy, snehasish, ormris, wenlei, steven_wu, hiraditya.
Herald added a project: All.
labrinea requested review of this revision.
Herald added a subscriber: pcwang-thead.
Herald added a project: LLVM.

Using AvgLoopIters on any loop is too imprecise making the cost model favor users inside loop nests regardless of the actual tripcount.

**Compile times -O3**

| benchmark        | nspecs before | nspecs after | instrCnt delta % |
| ClamAV           | 5             | 5            | +0.006           |
| 7zip             |               |              | -0.031           |
| tramp3d-v4       |               |              | -0.043           |
| kimwitu++        |               |              | -0.156           |
| sqlite3          | 2             |              | -0.571           |
| mafft            |               |              | -0.029           |
| lencod           |               |              | +0.029           |
| SPASS            | 2             | 2            | -0.038           |
| consumer-typeset |               |              | -0.045           |
| Bullet           |               | 1            | +0.055           |
| geomean          |               |              | -0.083           |
|

**Compile times LTO**

| benchmark        | nspecs before | nspecs after | instrCnt delta % |
| ClamAV           | 1             |              | -0.159           |
| 7zip             |               |              | -0.023           |
| tramp3d-v4       |               |              | -0.018           |
| kimwitu++        |               |              | +0.016           |
| sqlite3          | 2             | 1            | +0.357           |
| mafft            |               |              | +0.029           |
| lencod           |               |              | 0                |
| SPASS            | 1             |              | -0.283           |
| consumer-typeset |               | 1            | +0.539           |
| Bullet           |               |              | +0.013           |
| geomean          |               |              | +0.047           |


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D150375

Files:
  llvm/include/llvm/Transforms/IPO/FunctionSpecialization.h
  llvm/include/llvm/Transforms/Utils/SCCPSolver.h
  llvm/lib/Transforms/IPO/FunctionSpecialization.cpp
  llvm/lib/Transforms/IPO/SCCP.cpp
  llvm/lib/Transforms/Utils/SCCPSolver.cpp
  llvm/test/Other/new-pm-defaults.ll
  llvm/test/Other/new-pm-lto-defaults.ll
  llvm/test/Other/new-pm-thinlto-postlink-defaults.ll
  llvm/test/Other/new-pm-thinlto-postlink-pgo-defaults.ll
  llvm/test/Other/new-pm-thinlto-postlink-samplepgo-defaults.ll
  llvm/test/Transforms/FunctionSpecialization/function-specialization-always-inline.ll
  llvm/test/Transforms/FunctionSpecialization/function-specialization-constant-integers.ll
  llvm/test/Transforms/FunctionSpecialization/function-specialization-loop.ll
  llvm/test/Transforms/FunctionSpecialization/function-specialization2.ll
  llvm/test/Transforms/FunctionSpecialization/function-specialization3.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150375.521317.patch
Type: text/x-patch
Size: 39856 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230511/c966f95f/attachment-0001.bin>