[PATCH] D150286: [RISCV] Fold (select setcc, setcc, setcc) into and/or instructions

[Yingwei Zheng via Phabricator via llvm-commits]

dtcxzyw marked an inline comment as done.
dtcxzyw added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:5354
+
+static SetCCCompareResult compareSetCC(SDValue LHS, SDValue RHS,
+                                       ISD::CondCode CC, SDValue Val) {
----------------
craig.topper wrote:
> Can we return std::optional<bool> similar to `isImpliedCondition` from lib/Analysis/ValueTracking. I think this is very similar to that.
Thank you for your suggestion.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150286/new/

https://reviews.llvm.org/D150286