[PATCH] D149423: [ValueTracking] Use knownbits interface for determining if `div`/`rem` are safe to speculate

[luxufan via Phabricator via llvm-commits]

StephenFan added a comment.

> Short term fix is obviously revert (still building), but longer term
> I guess we need an API for "is always speculatively executable"?
> or something like that.
> @nikic, any thoughts on how best to proceed in trying to safely
> strengthen the `isSpeculativelyExecutable` case?

I think strengthening the 'isSpeculativlyExecutable' is a bit conservative. I found that this bug is only exposed in CVP's narrowUDivOrURem, we can add some checks to avoid it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149423/new/

https://reviews.llvm.org/D149423