[PATCH] D150230: [GlobalISel] Implement some binary reassociations, G_ADD for now

[Thorsten via Phabricator via llvm-commits]

tschuett added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:4492
+          isConstantOrConstantSplatVector(*MRI.getVRegDef(OpLHSRHS), MRI)) {
+    if (auto C2 = isConstantOrConstantSplatVector(*OpRHSDef, MRI)) {
+      // (Opc (Opc X, C1), C2) -> (Opc X, (Opc C1, C2))
----------------
Could you turn the auto's into bool's? C1 and C2 are know only for documentation?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150230/new/

https://reviews.llvm.org/D150230