[PATCH] D150305: ObjCopy: support `--dump-section` on COFF

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexander-shaposhnikov accepted this revision.
alexander-shaposhnikov added a comment.
This revision is now accepted and ready to land.

minor nits inline, otherwise looks good to me.



================
Comment at: llvm/lib/ObjCopy/COFF/COFFObjcopy.cpp:145
+
+    std::copy(Contents.begin(), Contents.end(), Buffer->getBufferStart());
+    if (Error E = Buffer->commit())
----------------
nit: 
```
llvm::copy(Contents, Buffer->getBufferStart());
```


================
Comment at: llvm/lib/ObjCopy/COFF/COFFObjcopy.cpp:159
+    StringRef Section, File;
+    std::tie(Section, File) = Op.split('=');
+    if (Error E = dumpSection(Obj, Section, File))
----------------
nit:
```
auto [Section, File] = Op.split('=');
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150305/new/

https://reviews.llvm.org/D150305