[PATCH] D149549: [compiler-rt][interception][win] Don't crash on unknown instructions

Wed May 10 15:56:53 PDT 2023

mstorsjo added a comment.

In D149549#4333493 <https://reviews.llvm.org/D149549#4333493>, @ayzhao wrote:

> We're starting to see build failures due to interception_failure_test.cpp <https://github.com/llvm/llvm-project/blob/main/compiler-rt/test/asan/TestCases/interception_failure_test.cpp> unexpectedly passing on Windows: https://crbug.com/1443891

Hmmm - I guess it's concievable that this makes it no longer crash where it used to, so in that case the right course of action would be to remove the `XFAIL` in this case? The message for the `XFAIL` seems to be something different than what we're dealing with here though - but it's possible that the testcase, before this patch, used to fail for a new/different reason than what it was originally marked as `XFAIL` for.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149549/new/

https://reviews.llvm.org/D149549