[PATCH] D149124: [llvm-profdata] ProfileReader cleanup - preparation for MD5 refactoring - 3

William Junda Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 10 11:34:47 PDT 2023


huangjd added inline comments.


================
Comment at: llvm/lib/ProfileData/SampleProfReader.cpp:773-776
+  // If the profile is MD5, use the map container to lookup functions in
+  // the module. A remapper has no use on MD5 names.
+  if (useMD5())
+    return false;
----------------
wenlei wrote:
> Do we need a separate entry for this? Or merge it with the `return false` in the end?
I am keeping the logic in this order so that it is consistent with the control flow in readFuncProfiles because it is very complicated. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149124/new/

https://reviews.llvm.org/D149124



More information about the llvm-commits mailing list