[PATCH] D150249: [X86] Improve handling on zero constant for fminimum/fmaximum lowering
Noah Goldstein via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 10 10:57:17 PDT 2023
goldstein.w.n added inline comments.
================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:30299
// to ensure the correct zero is returned.
- auto IsPreferredZero = [PreferredZero](SDValue Op) {
+ auto MatchesZero = [](SDValue Op, APInt PreferredZero) {
Op = peekThroughBitcasts(Op);
----------------
nit: can you use a different variable name than `PreferredZero` as the value in the lambda doesn't always match whats in the outerscope.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150249/new/
https://reviews.llvm.org/D150249
More information about the llvm-commits
mailing list