[PATCH] D150230: [GlobalISel] Implement some binary reassociations, G_ADD for now

Thorsten via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 10 10:47:09 PDT 2023


tschuett added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:4492
+      isConstantOrConstantSplatVector(*MRI.getVRegDef(Op01), MRI);
+  std::optional<APInt> C2;
+  if (C1) {
----------------
Did you hoist `C2`out of the if for future work?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150230/new/

https://reviews.llvm.org/D150230



More information about the llvm-commits mailing list