[PATCH] D135663: [libunwind] Install the headers by default

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 10 10:33:44 PDT 2023


barannikov88 added a comment.

In D135663#4332576 <https://reviews.llvm.org/D135663#4332576>, @ldionne wrote:

> I am not sure why a freestanding implementation would require `<unwind.h>`, but if it does, then my reflex would be to say that it should get it from its unwinder library (aka `libunwind` or other). In my mind, freestanding is not the same as "no runtime libraries". If you are in freestanding and you still want exceptions, you'll need some unwind library to support that no matter what.

I agree.

> So naively, I'd be fine with removing the Clang version, but I wouldn't be surprised if there's a bunch of reasons why this can't work. If you want, you could create a review and we can have a discussion and ping the right people on it.

I'll try not to forget to create a review when I have more time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D135663/new/

https://reviews.llvm.org/D135663



More information about the llvm-commits mailing list