[PATCH] D148584: [FS-AFDO] Load pseudo probe profile on MIR

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/test/Transforms/SampleProfile/pseudo-probe-profile-mismatch.ll:235
 !62 = !DILocation(line: 16, column: 19, scope: !63)
-!63 = !DILexicalBlockFile(scope: !58, file: !3, discriminator: 2)
+!63 = !DILexicalBlockFile(scope: !58, file: !3, discriminator: 0)
 !64 = !DILocation(line: 16, column: 21, scope: !63)
----------------
wenlei wrote:
> what change caused these discriminator diffs? I thought only the first patch in the stack could affect this.
Yeah, with the first patch there should be no probes on the IR with non-zero discriminators initially, so I'm cleaning up here. 

The change should be belong to the first patch. I can move it over there. It shouldn't be needed by this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148584/new/

https://reviews.llvm.org/D148584