[PATCH] D147651: [PseudoProbe] Encode/Decode FS discriminator

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 10 09:58:42 PDT 2023


hoy added inline comments.


================
Comment at: llvm/include/llvm/IR/PseudoProbe.h:95
 
+static inline bool HasDiscriminator(uint32_t Flags) {
+  return Flags & (uint32_t)PseudoProbeAttributes::HasDiscriminator;
----------------
wenlei wrote:
> nit: these helper function seem to start with lower case initial?
Good catch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147651/new/

https://reviews.llvm.org/D147651



More information about the llvm-commits mailing list