[llvm] fae9e7d - AMDGPU: Factor out GFX9.4 common features into a feature set

[Konstantin Zhuravlyov via llvm-commits]

Author: Konstantin Zhuravlyov
Date: 2023-05-10T11:51:06-04:00
New Revision: fae9e7d46ce52cce3a1f7c7cd0011f2eb1b1d0a8

URL: https://github.com/llvm/llvm-project/commit/fae9e7d46ce52cce3a1f7c7cd0011f2eb1b1d0a8
DIFF: https://github.com/llvm/llvm-project/commit/fae9e7d46ce52cce3a1f7c7cd0011f2eb1b1d0a8.diff

LOG: AMDGPU: Factor out GFX9.4 common features into a feature set

Differential Revision: https://reviews.llvm.org/D149985

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/AMDGPU.td

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/AMDGPU.td b/llvm/lib/Target/AMDGPU/AMDGPU.td
index f9608ad05df0..0fd73ba88b1f 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPU.td
+++ b/llvm/lib/Target/AMDGPU/AMDGPU.td
@@ -1193,7 +1193,7 @@ def FeatureISAVersion9_0_C : FeatureSet<
    FeatureMadMacF32Insts,
    FeatureImageGather4D16Bug]>;
 
-def FeatureISAVersion9_4_0 : FeatureSet<
+def FeatureISAVersion9_4_Common : FeatureSet<
   [FeatureGFX9,
    FeatureGFX90AInsts,
    FeatureGFX940Insts,
@@ -1227,73 +1227,17 @@ def FeatureISAVersion9_4_0 : FeatureSet<
    FullRate64Ops,
    FeatureBackOffBarrier]>;
 
+def FeatureISAVersion9_4_0 : FeatureSet<
+  !listconcat(FeatureISAVersion9_4_Common.Features,
+    [])>;
+
 def FeatureISAVersion9_4_1 : FeatureSet<
-  [FeatureGFX9,
-   FeatureGFX90AInsts,
-   FeatureGFX940Insts,
-   FeatureFmaMixInsts,
-   FeatureLDSBankCount32,
-   FeatureDLInsts,
-   FeatureFmacF64Inst,
-   FeatureDot1Insts,
-   FeatureDot2Insts,
-   FeatureDot3Insts,
-   FeatureDot4Insts,
-   FeatureDot5Insts,
-   FeatureDot6Insts,
-   FeatureDot7Insts,
-   FeatureDot10Insts,
-   FeatureAtomicDsPkAdd16Insts,
-   FeatureAtomicFlatPkAdd16Insts,
-   Feature64BitDPP,
-   FeaturePackedFP32Ops,
-   FeatureMAIInsts,
-   FeatureFP8Insts,
-   FeaturePkFmacF16Inst,
-   FeatureAtomicFaddRtnInsts,
-   FeatureAtomicFaddNoRtnInsts,
-   FeatureAtomicBufferGlobalPkAddF16Insts,
-   FeatureAtomicGlobalPkAddBF16Inst,
-   FeatureFlatAtomicFaddF32Inst,
-   FeatureSupportsSRAMECC,
-   FeaturePackedTID,
-   FeatureArchitectedFlatScratch,
-   FullRate64Ops,
-   FeatureBackOffBarrier]>;
+  !listconcat(FeatureISAVersion9_4_Common.Features,
+    [])>;
 
 def FeatureISAVersion9_4_2 : FeatureSet<
-  [FeatureGFX9,
-   FeatureGFX90AInsts,
-   FeatureGFX940Insts,
-   FeatureFmaMixInsts,
-   FeatureLDSBankCount32,
-   FeatureDLInsts,
-   FeatureFmacF64Inst,
-   FeatureDot1Insts,
-   FeatureDot2Insts,
-   FeatureDot3Insts,
-   FeatureDot4Insts,
-   FeatureDot5Insts,
-   FeatureDot6Insts,
-   FeatureDot7Insts,
-   FeatureDot10Insts,
-   FeatureAtomicDsPkAdd16Insts,
-   FeatureAtomicFlatPkAdd16Insts,
-   Feature64BitDPP,
-   FeaturePackedFP32Ops,
-   FeatureMAIInsts,
-   FeatureFP8Insts,
-   FeaturePkFmacF16Inst,
-   FeatureAtomicFaddRtnInsts,
-   FeatureAtomicFaddNoRtnInsts,
-   FeatureAtomicBufferGlobalPkAddF16Insts,
-   FeatureAtomicGlobalPkAddBF16Inst,
-   FeatureFlatAtomicFaddF32Inst,
-   FeatureSupportsSRAMECC,
-   FeaturePackedTID,
-   FeatureArchitectedFlatScratch,
-   FullRate64Ops,
-   FeatureBackOffBarrier]>;
+  !listconcat(FeatureISAVersion9_4_Common.Features,
+    [])>;
 
 // TODO: Organize more features into groups.
 def FeatureGroup {