[PATCH] D150251: [SystemZ] Bugfix in expansion of memmem operations.

Jonas Paulsson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 10 02:56:59 PDT 2023


jonpa updated this revision to Diff 520945.
jonpa added a comment.

The new test case when run with expensive checks showed that the NoPHIs flag needs to be cleared.

Not sure why this has not been reported before - perhaps due to the new .mir test case starting before finalize-isel.

Should I pre-commit that and then also backport both patches?

Alternatively, we could just stop the test after finalize-isel and make sure the CC operand is there as needed...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150251/new/

https://reviews.llvm.org/D150251

Files:
  llvm/lib/Target/SystemZ/SystemZISelLowering.cpp
  llvm/test/CodeGen/SystemZ/memmem-exrl-cc.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150251.520945.patch
Type: text/x-patch
Size: 4432 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230510/012e1216/attachment.bin>


More information about the llvm-commits mailing list