[PATCH] D150256: [NFC]add mov constructor to DIEValue

[Wang, Xin via Phabricator via llvm-commits]

XinWang10 added inline comments.


================
Comment at: llvm/include/llvm/DWARFLinker/DWARFLinkerCompileUnit.h:38
+    *I =
+        std::move(DIEValue(Old.getAttribute(), Old.getForm(), DIEInteger(New)));
   }
----------------
barannikov88 wrote:
> std::move is redundant here, the expression is already xvalue.
> The same is true in other places.
> 
Oh, sorry, my mistake, so you are right, we don't need move construct


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150256/new/

https://reviews.llvm.org/D150256