[PATCH] D150256: [NFC]add mov constructor to DIEValue

Sergei Barannikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 10 02:33:55 PDT 2023


barannikov88 added inline comments.


================
Comment at: llvm/include/llvm/DWARFLinker/DWARFLinkerCompileUnit.h:38
+    *I =
+        std::move(DIEValue(Old.getAttribute(), Old.getForm(), DIEInteger(New)));
   }
----------------
std::move is redundant here, the expression is already xvalue.
The same is true in other places.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150256/new/

https://reviews.llvm.org/D150256



More information about the llvm-commits mailing list